Message128210
Thanks for doing this. Looking at the patch: Modules/_io/_iomodule.h has macros for dealing with off_t (it also defines Py_off_t for Windows), perhaps you want to use them.
Also, support.unlink() takes care of ignoring ENOENT for you.
Regardling the sizes used in the test: I think using hexadecimal literals (e.g. 0x180000000 instead of 6442450944) would make things a bit more readable :)
Part of the patch doesn't apply cleanly to latest py3k. Could you regenerate it, please? |
|
Date |
User |
Action |
Args |
2011-02-09 12:54:18 | pitrou | set | recipients:
+ pitrou, loewis, vstinner, nadeem.vawda, eckhardt, saa, rosslagerwall, jbeezley |
2011-02-09 12:54:18 | pitrou | set | messageid: <1297256058.48.0.0878097918617.issue4681@psf.upfronthosting.co.za> |
2011-02-09 12:54:13 | pitrou | link | issue4681 messages |
2011-02-09 12:54:13 | pitrou | create | |
|