Author jdennis
Recipients eric.araujo, jdennis, tarek
Date 2011-02-03.00:05:43
SpamBayes Score 9.03551e-11
Marked as misclassified No
Message-id <1296691544.53.0.327829038157.issue11104@psf.upfronthosting.co.za>
In-reply-to
Content
The behaviour of sdist has changed dramatically in Python 2.7. Some projects prefer to maintain their own manifest file instead of utilizing automatic manifest generation from a template. The defined behaviour of sdist is to check for the presence of both a template and a manifest, if the template is absent but a manifest exists sdist is supposed to read the existing manifest, it no longer does this. Instead it creates a default file list with the catastrophic result of omitting the bulk of a projects files.  

It appears this bug was introduced in r81255 and is discussed in #8688. Unfortunately #8688 contained a number of different issues and was closed addressing only a subset of the problems. Changeset r83996 was introduced to prevent sdist from overwriting a project maintained manifest by testing for a comment at the head of the manifest file. It's not clear to me this was necessary because the write_manifest() should never have been called if the template was absent but a manifest existed.

Even after the application of changeset r83996 one of the fundamental problems in #8688 remained, the manifest is not read. The solution is to check for both the manifest and template (as was formerly done) and if the template is absent but the manifest exists then the manifest should be read.

I have made modifications to get_file_list() to reintroduce the defined behaviour. With the introduction of r83996 it is now legal syntax to have comments in the manifest however read_manifest() was not enhanced to account for the possible presence of comments. I also modified read_manifest() to handle comments.

These suggested fixes are attached as a patch against the current 2.7 maintenance branch. I've also attached a file with the two modified methods because sometimes it's difficult to comprehend a patch.
History
Date User Action Args
2011-02-03 00:05:44jdennissetrecipients: + jdennis, tarek, eric.araujo
2011-02-03 00:05:44jdennissetmessageid: <1296691544.53.0.327829038157.issue11104@psf.upfronthosting.co.za>
2011-02-03 00:05:43jdennislinkissue11104 messages
2011-02-03 00:05:43jdenniscreate