Author giampaolo.rodola
Recipients brett.cannon, eli.bendersky, giampaolo.rodola, ncoghlan, pitrou, r.david.murray
Date 2011-01-29.14:41:03
SpamBayes Score 4.81621e-09
Marked as misclassified No
Message-id <1296312065.6.0.276350685534.issue11049@psf.upfronthosting.co.za>
In-reply-to
Content
> * class TestCase(unittest.TestCase): -> why not give the test class a 
> more useful name?

done

> * import_fresh_module is tested similarly to import_module - can't a 
> test be added that it indeed performs its "special sauce"?

Even by reading the source code I'm not sure what import_fresh_module does exactly.
Feel free to write a test for it if you want.

> * test_DirsOnSysPath: you may want to use assertIn and assertNotIn here. [these 
> were added to Python in 3.1]

done

> * test_python_is_optimized: you may want to use assertIsInstance here.

done

> +        os.mkdir(os.path.join(TESTFN, TESTFN))
> Please don't. This will break the day TESTFN becomes a non-trivial path.

done

> You should also check that the errno is EBADF.

Done. I just hope it's gonna be reliable on all platforms.
History
Date User Action Args
2011-01-29 14:41:05giampaolo.rodolasetrecipients: + giampaolo.rodola, brett.cannon, ncoghlan, pitrou, r.david.murray, eli.bendersky
2011-01-29 14:41:05giampaolo.rodolasetmessageid: <1296312065.6.0.276350685534.issue11049@psf.upfronthosting.co.za>
2011-01-29 14:41:03giampaolo.rodolalinkissue11049 messages
2011-01-29 14:41:03giampaolo.rodolacreate