Author r.david.murray
Recipients georg.brandl, giampaolo.rodola, holdenweb, lregebro, pitrou, r.david.murray, rhettinger, sdaoden, vstinner
Date 2011-01-29.14:35:21
SpamBayes Score 1.32742e-05
Marked as misclassified No
Message-id <1296311722.73.0.607720444594.issue9124@psf.upfronthosting.co.za>
In-reply-to
Content
Victor: yes, I was thinking that when I added that comment but forgot to come back to it.  Thanks for spotting that.

Another thing I forgot about yesterday is that I activated the commented out statements that do linesep transformations on the binary file data.  I'm guessing those were commented out when the module was converted to using text files, since the text file would do the transformation itself.  Your patch left them commented out, and the tests passed on Windows.  If the tests *still* pass on windows with them uncommented, then that will prove that, like the old email tests, the line ending variations aren't really being tested.

But, the important thing here is that I haven't run the tests on Windows yet, and that certainly needs to be done.
History
Date User Action Args
2011-01-29 14:35:22r.david.murraysetrecipients: + r.david.murray, georg.brandl, rhettinger, holdenweb, pitrou, vstinner, giampaolo.rodola, lregebro, sdaoden
2011-01-29 14:35:22r.david.murraysetmessageid: <1296311722.73.0.607720444594.issue9124@psf.upfronthosting.co.za>
2011-01-29 14:35:21r.david.murraylinkissue9124 messages
2011-01-29 14:35:21r.david.murraycreate