Author giampaolo.rodola
Recipients anacrolix, giampaolo.rodola, loewis, pitrou, rosslagerwall
Date 2011-01-28.20:07:48
SpamBayes Score 3.9021e-12
Marked as misclassified No
Message-id <1296245269.0.0.773981280097.issue10882@psf.upfronthosting.co.za>
In-reply-to
Content
> Copy *count* bytes from file descriptor *in* to file descriptor 
> *out*, starting at *offset* and continuing for *count* bytes.

The latter part is incorrect as it is not guaranteed that all bytes specified in "count" argument are going to be sent and it also sounds like the function is blocking.
I'd change that in just "Copy *count* bytes from file descriptor *in* to file descriptor *out*."

Also, I'd be for using the BSD notation and rename the "count" argument to "nbytes", which is more clear.

Docstring should be changed to reflect the keyword arguments:
- sendfile(out, in, offset, count, headers, trailers, flags)\n\
+ sendfile(out, in, offset, count[, headers[, trailers], flags]]])\n\

Finally, tests for header and trailer arguments should be written.

The rest of the patch looks ok to me.
History
Date User Action Args
2011-01-28 20:07:49giampaolo.rodolasetrecipients: + giampaolo.rodola, loewis, pitrou, anacrolix, rosslagerwall
2011-01-28 20:07:48giampaolo.rodolasetmessageid: <1296245269.0.0.773981280097.issue10882@psf.upfronthosting.co.za>
2011-01-28 20:07:48giampaolo.rodolalinkissue10882 messages
2011-01-28 20:07:48giampaolo.rodolacreate