This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author SilentGhost
Recipients SilentGhost, belopolsky, vrutsky
Date 2011-01-14.15:52:49
SpamBayes Score 2.1220248e-12
Marked as misclassified No
Message-id <1295020376.03.0.967767300509.issue10908@psf.upfronthosting.co.za>
In-reply-to
Content
In the course of fixing #10896 I've noticed a few things:

 1. --ignore-dir='$prefix' doesn't work on windows. I don't know if it has to, there is no information in docs regarding it at all. It does work on Unix.
 2. The way module check is done is inefficient.
 3. I'm not sure if filename could ever get the value of None in _Ignore.names (there is check for that though)
 4. it's not clear why _Ignore initialised with default values of None, that path was never exercised and while I've added a test for it, I'm actually not sure if it's needed.
 5. general clean up was needed for the code dealing with ignoring.

Attached is the patch.
 The only change, that I consider beneficial, is that the ignored dir doesn't have actually be a directory.
History
Date User Action Args
2011-01-14 15:52:56SilentGhostsetrecipients: + SilentGhost, belopolsky, vrutsky
2011-01-14 15:52:56SilentGhostsetmessageid: <1295020376.03.0.967767300509.issue10908@psf.upfronthosting.co.za>
2011-01-14 15:52:50SilentGhostlinkissue10908 messages
2011-01-14 15:52:49SilentGhostcreate