Author eric.araujo
Recipients benjamin.peterson, daniel.urban, eric.araujo, gvanrossum, kerio, pitrou, rhettinger
Date 2011-01-10.19:33:52
SpamBayes Score 1.53303e-06
Marked as misclassified No
Message-id <4D2B5F1C.7090608@netwok.org>
In-reply-to <1294685883.05.0.821639918123.issue10868@psf.upfronthosting.co.za>
Content
-            return  # Already a subclass
+            return subclass # Already a subclass
PEP 8 advises to put two spaces before inline comments, for readability.
 (There is no need to upload a new patch, I’ll change that before commit.)

+        self.assertIsInstahce(c, (A,))
This is fixed in the newest version of your patch.  Running tests before
uploading diffs catches such errors :)
History
Date User Action Args
2011-01-10 19:33:54eric.araujosetrecipients: + eric.araujo, gvanrossum, rhettinger, pitrou, benjamin.peterson, daniel.urban, kerio
2011-01-10 19:33:52eric.araujolinkissue10868 messages
2011-01-10 19:33:52eric.araujocreate