Message 124965 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	Justin.Cappos, bbangert, exarkun, giampaolo.rodola, loewis, ned.deily, nicdumz, pitrou, ronaldoussoren, rosslagerwall, roysmith
Date	2010-12-31.14:13:43
SpamBayes Score	0.00035945294
Marked as misclassified	No
Message-id	<1293804825.08.0.723795220366.issue7995@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the patch. Comments/questions: - please don't use C++-style comments ("//") in C code; some compilers can choke on them - should the code path be also enabled for netbsd? (or other variants?) - why does the test silence socket.error on accept()? - what if fcntl() returns -1? (unlikely I know)

Thanks for the patch. Comments/questions:
- please don't use C++-style comments ("//") in C code; some compilers can choke on them
- should the code path be also enabled for netbsd? (or other variants?)
- why does the test silence socket.error on accept()?
- what if fcntl() returns -1? (unlikely I know)

History
Date	User	Action	Args
2010-12-31 14:13:45	pitrou	set	recipients: + pitrou, loewis, ronaldoussoren, exarkun, roysmith, giampaolo.rodola, ned.deily, nicdumz, bbangert, Justin.Cappos, rosslagerwall
2010-12-31 14:13:45	pitrou	set	messageid: <1293804825.08.0.723795220366.issue7995@psf.upfronthosting.co.za>
2010-12-31 14:13:43	pitrou	link	issue7995 messages
2010-12-31 14:13:43	pitrou	create