This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Martin.Potthast
Recipients Martin.Potthast, orsenthil, r.david.murray
Date 2010-12-22.19:23:16
SpamBayes Score 0.00011808301
Marked as misclassified No
Message-id <1293045799.8.0.720226229295.issue10759@psf.upfronthosting.co.za>
In-reply-to
Content
Why not simply remove the additional check in line 168 and leave the responsibility to check the validity of its input to the unescape function (be it explicitly or, like now, lazily). That way, the code changes are minimal, the existing test covers the current issue, and the function gets more robust.

By the way, I came across this function via Stackoverflow:
http://stackoverflow.com/questions/2087370
History
Date User Action Args
2010-12-22 19:23:19Martin.Potthastsetrecipients: + Martin.Potthast, orsenthil, r.david.murray
2010-12-22 19:23:19Martin.Potthastsetmessageid: <1293045799.8.0.720226229295.issue10759@psf.upfronthosting.co.za>
2010-12-22 19:23:16Martin.Potthastlinkissue10759 messages
2010-12-22 19:23:16Martin.Potthastcreate