➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients Arfrever, barry, belopolsky, ezio.melotti, jhalcrow, lemburg, loewis, pitrou, valhallasw, vstinner
Date 2010-12-21.19:23:56
SpamBayes Score 5.150522e-09
Marked as misclassified No
Message-id <1292959443.04.0.220017242258.issue10254@psf.upfronthosting.co.za>
In-reply-to
Content 
In the new patch, issue10254b.diff, I've added a test that would crash unpatched code:

>>> unicodedata.normalize('NFC', 'C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸C̸Ç')
Segmentation fault

Martin, I still feel uneasy about the fixed size of the skipped buffer.  It is not obvious that skipped combining characters always get removed from the buffer before the next starter is processed.

I would really like another pair of eyes to look at this code before it goes in especially to 2.6.

Victor,

IIRC, you did some stress testing on random data.  I wonder if you could test this code after tightening the assert to cskipped < 4.  (The current theory is that this should be enough.)
History
Date User Action Args
2010-12-21 19:24:03belopolskysetrecipients: + belopolsky, lemburg, loewis, barry, pitrou, vstinner, ezio.melotti, Arfrever, jhalcrow, valhallasw
2010-12-21 19:24:03belopolskysetmessageid: <1292959443.04.0.220017242258.issue10254@psf.upfronthosting.co.za>
2010-12-21 19:23:57belopolskylinkissue10254 messages
2010-12-21 19:23:56belopolskycreate