This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author skip.montanaro
Recipients Martin.Budaj, andrewmcnamara, ned.deily, r.david.murray, skip.montanaro
Date 2010-12-19.14:19:39
SpamBayes Score 5.27356e-15
Marked as misclassified No
Message-id <1292768381.64.0.133118722718.issue10515@psf.upfronthosting.co.za>
In-reply-to
Content
I get two failures with David's latest patch.  Abstracting from
a lightly modified patch:

    sample was: 'a,b,"c,d"\r\ne,f,g', got: '', expected: ','
    sample was: '"a,b,c,d"\r\ne', got: '\r', expected: ''

In both cases I think the expected delimiter should be comma.
The code or regular expressions need to be fixed for the first
failure.  As I indicated earlier \r\n should never be split.
Also, for a single column CSV file I think the expected/default
delimiter should be a comma.

That said, does anyone think I should change the expected delimiter
for the first two tests at this point for 2.7?  The inputs and
expected delimiters are

    ('abcde', 'e'),
    ('a', 'e'),

Both seem wrong to me, but I understand that the behavior of 2.7
probably shouldn't change to accommodate fixing broken test cases.

I'm also a bit concerned about this construct:

    locals()['some name'] = f

I thought locals() wasn't guaranteed to actually refer to a 
persistent dictionary.  That is, it's fine if locals() builds
its dictionary on-the-fly then discards it.  Do we know for
a fact that when called during a class definition that locals()
returns the class's dictionary?  (This might only matter if
other dialects of Python try to reuse test_csv.py.)
History
Date User Action Args
2010-12-19 14:19:41skip.montanarosetrecipients: + skip.montanaro, andrewmcnamara, ned.deily, r.david.murray, Martin.Budaj
2010-12-19 14:19:41skip.montanarosetmessageid: <1292768381.64.0.133118722718.issue10515@psf.upfronthosting.co.za>
2010-12-19 14:19:39skip.montanarolinkissue10515 messages
2010-12-19 14:19:39skip.montanarocreate