Message123869
Hi Gregory,
will you backport Mirko's patches to subprocess32?
The last thing left in this bug is my proposal to change the default of close_fds to True to Windows too, but at the same time detect whether this is possible or not (depending on the pipe redirections).
So basically close_fds=True would be changed to mean "close the FDs, if it is possible, otherwise never mind". This is not a break in compatibility on Linux/UNIX (where it is always "possible"), nor Windows (where currently it just raises a ValueError if you ask it to raise close the file descriptors while doing redirections).
The rationale for this change is again cross-compatibility. I don't like when my code breaks because of a limitation of an OS that has a clear workaround. Subprocess is a high-level library after all, it's not like os.fork() or similar low-level libraries which expose the underlying platform differences. |
|
Date |
User |
Action |
Args |
2010-12-13 10:02:54 | Giovanni.Bajo | set | recipients:
+ Giovanni.Bajo, georg.brandl, gregory.p.smith, paul.moore, vstinner, jwilk, ned.deily, milko.krachounov |
2010-12-13 10:02:53 | Giovanni.Bajo | set | messageid: <1292234573.8.0.93576847893.issue7213@psf.upfronthosting.co.za> |
2010-12-13 10:02:49 | Giovanni.Bajo | link | issue7213 messages |
2010-12-13 10:02:48 | Giovanni.Bajo | create | |
|