This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients Martin.Budaj, andrewmcnamara, ned.deily, r.david.murray, skip.montanaro
Date 2010-12-11.03:46:52
SpamBayes Score 5.15977e-08
Marked as misclassified No
Message-id <1292039214.4.0.299971646352.issue10515@psf.upfronthosting.co.za>
In-reply-to
Content
What do you mean by "there is a test for this case in csv.py"?  If I run sniffer against "abcde\ndefgh\n" I get a delimiter of 'e'.  If I run it against 'a\nb\n', I get the could not determine delimiter error.

Attached is a reformulated test case that lets us see the errors individually and easily add more.  With this set of 10 tests, two pass without your patches (as you knew; those are your tests), and we have 4 failures and 4 errors.  With p1 applied we have 4 failures and 3 errors.  With p2 applied we have 5 failures.

As I said, I'm not at all sure what the results *should* be for various of these cases.  Certainly the long standing existing behavior seems to be to return one of the characters in an unquoted multicharacter sequence. 

That said, it seems like your patch p1 is good, but as you discovered not sufficient.
History
Date User Action Args
2010-12-11 03:46:54r.david.murraysetrecipients: + r.david.murray, skip.montanaro, andrewmcnamara, ned.deily, Martin.Budaj
2010-12-11 03:46:54r.david.murraysetmessageid: <1292039214.4.0.299971646352.issue10515@psf.upfronthosting.co.za>
2010-12-11 03:46:52r.david.murraylinkissue10515 messages
2010-12-11 03:46:52r.david.murraycreate