Author ncoghlan
Recipients belopolsky, eric.araujo, georg.brandl, ncoghlan, ping, r.liebscher, ron_adam
Date 2010-11-19.15:40:11
SpamBayes Score 0.000134051
Marked as misclassified No
Message-id <1290181213.54.0.276413617593.issue2001@psf.upfronthosting.co.za>
In-reply-to
Content
Gah, I accidentally generated a diff that included some unrelated changes to urrlib (and its tests) for a different issue I had been working on, and Ron's subsequent patch picked them up. I then misinterpreted "left them alone" to mean "didn't include them in the regenerated patch". Sorry about that - taking those changes out was the right thing to do.

The test_pyclbr change was necessary at the time (the new code isn't particularly class browser friendly, so the tests referencing pydoc started failing), but it shouldn't be needed now that the server and client implementation details are once again hidden inside function scopes.
History
Date User Action Args
2010-11-19 15:40:13ncoghlansetrecipients: + ncoghlan, ping, georg.brandl, belopolsky, ron_adam, eric.araujo, r.liebscher
2010-11-19 15:40:13ncoghlansetmessageid: <1290181213.54.0.276413617593.issue2001@psf.upfronthosting.co.za>
2010-11-19 15:40:11ncoghlanlinkissue2001 messages
2010-11-19 15:40:11ncoghlancreate