Author eli.bendersky
Recipients docs@python, eli.bendersky, eric.araujo, ezio.melotti, georg.brandl, terry.reedy
Date 2010-11-19.06:30:21
SpamBayes Score 1.44049e-09
Marked as misclassified No
Message-id <1290148223.25.0.486912968889.issue9312@psf.upfronthosting.co.za>
In-reply-to
Content
√Čric,

I went over both the diffs and the HTML output from "make clean html" on the latest 3.2 trunk. Looks good to me!

Just a tiny nit re unittest.rst, where it says "supports three command-line options". This is the kind of comment that gets left behind when new options are added. I see no added value explicitly saying there are 3 options as opposed to "supports the following command-line options", and there's less chance for future mistakes. It's also more consistent with the list of options for "discover" a bit later in the same document. This is totally a stylistic issue, of course, so IMVHO :-)

Oh, and another thing about unittest.rst: in 24.3.9 where it says "The -c command-line option to unittest", for some reason the -c didn't get linked to the option, although I think you intended it to, since you marked it as :option:

P.S: the program/cmdoption combo idea was Georg's.
History
Date User Action Args
2010-11-19 06:30:23eli.benderskysetrecipients: + eli.bendersky, georg.brandl, terry.reedy, ezio.melotti, eric.araujo, docs@python
2010-11-19 06:30:23eli.benderskysetmessageid: <1290148223.25.0.486912968889.issue9312@psf.upfronthosting.co.za>
2010-11-19 06:30:21eli.benderskylinkissue9312 messages
2010-11-19 06:30:21eli.benderskycreate