Message121214
Thomas, I think the weirdness you were sensing when trying to adapt the nameCheck calls in test__RandomNameSequence after adding the abspath check is that those test cases really don't need nameCheck.
For example, test_get_six_char_str should be testing that _RandomNameSequence returns something that is both a string and 6 characters, not properties of some path manufactured around it.
I've attached a patch based on Thomas's that factors out the string check in nameCheck and has the tests in test__RandomNameSequence just use the string check.
The patch is against release27-maint. |
|
Date |
User |
Action |
Args |
2010-11-15 04:04:36 | jesstess | set | recipients:
+ jesstess, brett.cannon, roysmith, pitrou, dstanek, r.david.murray, thomas.holmes, BreamoreBoy |
2010-11-15 04:04:36 | jesstess | set | messageid: <1289793876.46.0.757680234219.issue7325@psf.upfronthosting.co.za> |
2010-11-15 04:04:33 | jesstess | link | issue7325 messages |
2010-11-15 04:04:33 | jesstess | create | |
|