Author pitrou
Recipients StevenJ, ajvant, chasonr, christian.heimes, giampaolo.rodola, janssen, jelie, pitrou
Date 2010-11-06.11:48:19
SpamBayes Score 1.17278e-06
Marked as misclassified No
Message-id <1289044096.3550.9.camel@localhost.localdomain>
In-reply-to <1289041535.83.0.255043312776.issue1926@psf.upfronthosting.co.za>
Content
Thanks for the patch, Andrew. It looks mostly good.

I would rename setreadermode to _setreadermode (there's no reason to
make it public IMO). Also, I would not explicitly check "STARTTLS" in
the capabilities. It the server doesn't support it, it will issue an
error anyway. Some servers might support it without advertising it, who
knows?

I can take care of all that when committing, you don't need to submit a
new patch (you can of course, if you want).

> (in fact I think usenetrc should be false by default for this reason,
> but I figure that would break backwards compatibility for programs
> that rely on it being true by default, and I'm not sure what the rules
> are regarding this) 

In 3.2, the reworked nntplib already breaks compatibility. It is
reasonable to switch the default for usenetrc to False; but I prefer to
do it in a separate commit for clarity.
History
Date User Action Args
2010-11-06 11:48:25pitrousetrecipients: + pitrou, janssen, giampaolo.rodola, christian.heimes, chasonr, ajvant, jelie, StevenJ
2010-11-06 11:48:23pitroulinkissue1926 messages
2010-11-06 11:48:22pitroucreate