Author ezio.melotti
Recipients ezio.melotti, michael.foord, pitrou, rhettinger
Date 2010-11-01.14:01:18
SpamBayes Score 2.47025e-13
Marked as misclassified No
Message-id <1288620081.44.0.928647349583.issue10273@psf.upfronthosting.co.za>
In-reply-to
Content
* I would leave assert<type>Equal documented and specify that they should be called directly only if the type should be checked, otherwise (if the type doesn't matter or it's already tested elsewhere) using assertEqual is enough (see also the suggestions in msg120124). -0.5 about dedocumenting, +1 on better documentation, possibly in an "advanced" section of the doc (I also find useful to know how assertEqual works and that I can register new functions like assert<type>Equal).

* assertLT and friends wouldn't match with assertEqual and assertNotEqual (assertEQ, assertNE?). Also these names don't seem more obvious or readable than assertLess, and will just add confusion and duplication of names, so -1.

* FWIW I like 'Regex' more than 'Regexp' too, assuming that it's worth renaming these methods and deprecate the old names (they are already in 2.7). Having a 'Match' or 'Search' suffix might clarify what the method does -- if it does what it says. +0 on the renaming (and +1 to 'Regex' if the rename happens).

* as I said on IRC, assertItemsEqual provides an useful functionality, and even if the name is not 100% clear, I'd rather double-check the doc than having to reimplement the functionality myself (or having a clumsy long-but-clear name). -1 on the removal, +1 on better documentation/performance.

* I think assertIsInstance is fine, however I wonder why the opposite is not assertIsNotInstance. Anyway it's probably not worth creating more confusion and adding new names just to change the spelling (they are in 2.7 too).
History
Date User Action Args
2010-11-01 14:01:21ezio.melottisetrecipients: + ezio.melotti, rhettinger, pitrou, michael.foord
2010-11-01 14:01:21ezio.melottisetmessageid: <1288620081.44.0.928647349583.issue10273@psf.upfronthosting.co.za>
2010-11-01 14:01:19ezio.melottilinkissue10273 messages
2010-11-01 14:01:18ezio.melotticreate