Author scoder
Recipients kristjan.jonsson, pitrou, scoder
Date 2010-11-01.09:18:15
SpamBayes Score 3.21659e-08
Marked as misclassified No
Message-id <1288603097.61.0.165840188122.issue10227@psf.upfronthosting.co.za>
In-reply-to
Content
I find it a lot easier to appreciate patches that implement a single change than those that mix different changes. There are three different things in your patch, which I would like to see in at least three different commits. I'd be happy if you could separate the changes into more readable feature patches. That makes it easier to accept them.

I'm generally happy about the slice changes, but you will have to benchmark the equivalent changes in Py3.2 to prove that they are similarly worth applying there.
History
Date User Action Args
2010-11-01 09:18:17scodersetrecipients: + scoder, pitrou, kristjan.jonsson
2010-11-01 09:18:17scodersetmessageid: <1288603097.61.0.165840188122.issue10227@psf.upfronthosting.co.za>
2010-11-01 09:18:15scoderlinkissue10227 messages
2010-11-01 09:18:15scodercreate