Author bbrazil
Recipients bbrazil
Date 2010-10-30.14:59:05
SpamBayes Score 2.70758e-06
Marked as misclassified No
Message-id <1288450748.11.0.919591582507.issue10253@psf.upfronthosting.co.za>
In-reply-to
Content
fileio_init will leak a fd if you open a file for append that isn't seekable. We should close this fd before returning the failure.

The attached patch fixes this and a resource warning in the tests, but I'm unsure if it'd be better to use internal_close. I'd want the error from the seek rather than any potential error from the close, so I think this is okay.

Regrtest is happy.
History
Date User Action Args
2010-10-30 14:59:08bbrazilsetrecipients: + bbrazil
2010-10-30 14:59:08bbrazilsetmessageid: <1288450748.11.0.919591582507.issue10253@psf.upfronthosting.co.za>
2010-10-30 14:59:06bbrazillinkissue10253 messages
2010-10-30 14:59:06bbrazilcreate