Author r.david.murray
Recipients jldm, r.david.murray
Date 2010-10-26.13:29:15
SpamBayes Score 5.91661e-10
Marked as misclassified No
Message-id <1288099757.6.0.0611339323837.issue10197@psf.upfronthosting.co.za>
In-reply-to
Content
Oddly, the test suite skips getoutput and getstatusoutput on windows with the comment that the source says it is relevant only for posix, but the documentation does not have 'availability: unix' tags.  (It is also odd that getoutput isn't documented, but that's a different issue.)

Your workaround can't be used as a fix, since the semantics of {}s in the shell are different from those of ()s.

It's not clear to me what the point of the {}s is, but I have a fear that eliminating them would introduce subtle changes in the behavior of getoutput calls.  Perhaps not, though.

It looks like this issue amounts to an RFE for support of getoutput/getstatusoutput on Windows, though the fact that it is not documented as unix-only may make it a bug instead :)

The appropriate fix is probably to conditionalize the code based on platform.  A complete patch will require unit test changes and documentation changes (since the docs currently mention the braces).

All of that said, it also appears that the new check_output should be preferred to either getoutput or getstatusoutput.  Perhaps those functions could be re-implemented in terms of check_output.
History
Date User Action Args
2010-10-26 13:29:17r.david.murraysetrecipients: + r.david.murray, jldm
2010-10-26 13:29:17r.david.murraysetmessageid: <1288099757.6.0.0611339323837.issue10197@psf.upfronthosting.co.za>
2010-10-26 13:29:16r.david.murraylinkissue10197 messages
2010-10-26 13:29:15r.david.murraycreate