Author pitrou
Recipients BreamoreBoy, Garen, belopolsky, bretthoerner, chrismiles, danchr, dhduvall, dmalcolm, fche, glyph, jbaker, jcea, laca, mjw, movement, pitrou, rhettinger, robert.kern, ronaldoussoren, sirg3, techtonik, twleung, wsanchez
Date 2010-10-25.21:42:33
SpamBayes Score 6.16403e-08
Marked as misclassified No
Message-id <1288042950.3589.18.camel@localhost.localdomain>
In-reply-to <1288041653.29.0.548287791975.issue4111@psf.upfronthosting.co.za>
Content
> I've wrapped the whole of get_frame_marker_info with a
> PyErr_Fetch/PyErr_Restore pair: the PyUnicode_AsUTF8String calls could
> fail with a MemoryError, and we don't want to confuse the regular
> exception handling within ceval.

If PyUnicode_AsUTF8String() is meant to encode a filename, you should
use PyUnicode_EncodeFSDefault() instead.

> The non-ASCII script name (Lib/test/systemtap_sample_☠.py) may be
> controversial: do we have anything like that in the source tree yet?
> Is there any risk of messing up the build across platforms, or of
> impacting the Hg migration?

It would be better to generate the sample dynamically, so that users
with an incompatible locale or filesystem aren't prevented from checking
out the source.
History
Date User Action Args
2010-10-25 21:42:35pitrousetrecipients: + pitrou, rhettinger, jcea, ronaldoussoren, belopolsky, wsanchez, movement, techtonik, glyph, bretthoerner, laca, twleung, jbaker, robert.kern, sirg3, chrismiles, danchr, dhduvall, dmalcolm, mjw, Garen, BreamoreBoy, fche
2010-10-25 21:42:33pitroulinkissue4111 messages
2010-10-25 21:42:33pitroucreate