This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author dmalcolm
Recipients BreamoreBoy, Garen, belopolsky, bretthoerner, chrismiles, danchr, dhduvall, dmalcolm, fche, glyph, jbaker, jcea, laca, mjw, movement, pitrou, rhettinger, robert.kern, ronaldoussoren, sirg3, techtonik, twleung, wsanchez
Date 2010-10-25.21:20:49
SpamBayes Score 5.9678373e-12
Marked as misclassified No
Message-id <1288041653.29.0.548287791975.issue4111@psf.upfronthosting.co.za>
In-reply-to
Content
Updated patch, removing the FIXMEs, and slightly reworking the test code.

I've wrapped the whole of get_frame_marker_info with a PyErr_Fetch/PyErr_Restore pair: the PyUnicode_AsUTF8String calls could fail with a MemoryError, and we don't want to confuse the regular exception handling within ceval.

I'm not sure how to write a unit test to test for this: perhaps we could corrupt the __code__ instance so that co_filename is not a PyUnicodeObject, leading to a TypeError within the function, but that's a readonly attribute.  Any ideas?

I've also added a unit test for a non-ASCII script (Lib/test/systemtap_sample_☠.py), containing a non-ASCII identifier (文字化け).

The non-ASCII script name (Lib/test/systemtap_sample_☠.py) may be controversial: do we have anything like that in the source tree yet?  Is there any risk of messing up the build across platforms, or of impacting the Hg migration?

Still to-do:
  - address the "Undefined symbol" issues seen by jcea.
  - documentation
  - doublecheck performance
History
Date User Action Args
2010-10-25 21:20:53dmalcolmsetrecipients: + dmalcolm, rhettinger, jcea, ronaldoussoren, belopolsky, pitrou, wsanchez, movement, techtonik, glyph, bretthoerner, laca, twleung, jbaker, robert.kern, sirg3, chrismiles, danchr, dhduvall, mjw, Garen, BreamoreBoy, fche
2010-10-25 21:20:53dmalcolmsetmessageid: <1288041653.29.0.548287791975.issue4111@psf.upfronthosting.co.za>
2010-10-25 21:20:51dmalcolmlinkissue4111 messages
2010-10-25 21:20:51dmalcolmcreate