Message119264
Modules/operator.c grows by ~70 lines, most of it the setup code for ag->attr; also I loop twice over the args of attrgetter_new, choosing fast code that runs once per attrgetter creation than temporary data.
Alex's suggestion to make use of Python-level functions to shorten the code of attrgetter_new could obviously work to decrease the source lines. I don't know how fast I would produce such a version if requested, though.
Whatever the way attrgetter_new sets up the data, I would suggest that you keep the logic changes in general, i.e. set-up in attrgetter_new and keep a thinner dotted_getattr , since it avoids running the same checks and splitting over and over again for every attrgetter_call invocation. |
|
Date |
User |
Action |
Args |
2010-10-21 06:56:01 | tzot | set | recipients:
+ tzot, rhettinger, alex, docs@python |
2010-10-21 06:56:01 | tzot | set | messageid: <1287644161.72.0.406199879747.issue10160@psf.upfronthosting.co.za> |
2010-10-21 06:56:00 | tzot | link | issue10160 messages |
2010-10-21 06:55:59 | tzot | create | |
|