Message 118653 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	loewis, vstinner
Date	2010-10-14.12:05:44
SpamBayes Score	2.9386086e-07
Marked as misclassified	No
Message-id	<1287057947.24.0.934485638362.issue10095@psf.upfronthosting.co.za>
In-reply-to

Content
> We shouldn't need to reopen the file in the first place. > If we already have a file handle, we can rewind it. > Then the encoding of the file name becomes irrelevant. Oh yes, great idea. r85476 implements this solution (use lseek(0) on fileno(tok->fp)). The code path exists but only if filename was NULL. But I don't think that it worked because there was no call to lseek(0). The commit fixes this issue (LANG= ./python -c "import inspect). I have other issues with "LANG= ./python Lib/test/regrtest.py -v test_pydoc test_traceback" but I think that it is a new (different) issue.

> We shouldn't need to reopen the file in the first place. 
> If we already have a file handle, we can rewind it.
> Then the encoding of the file name becomes irrelevant.

Oh yes, great idea. r85476 implements this solution (use lseek(0) on fileno(tok->fp)). The code path exists but only if filename was NULL. But I don't think that it worked because there was no call to lseek(0).

The commit fixes this issue (LANG= ./python -c "import inspect). I have other issues with "LANG= ./python Lib/test/regrtest.py -v test_pydoc test_traceback" but I think that it is a new (different) issue.

History
Date	User	Action	Args
2010-10-14 12:05:47	vstinner	set	recipients: + vstinner, loewis
2010-10-14 12:05:47	vstinner	set	messageid: <1287057947.24.0.934485638362.issue10095@psf.upfronthosting.co.za>
2010-10-14 12:05:45	vstinner	link	issue10095 messages
2010-10-14 12:05:44	vstinner	create