This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author barry
Recipients ajaksu2, barry, loewis, pitrou, r.david.murray, tlau
Date 2010-10-04.15:01:13
SpamBayes Score 1.3093293e-10
Marked as misclassified No
Message-id <>
RDM, I wonder if it wouldn't be better (in email6) to use an instance to represent the 3-tuple instead?  It might make for clearer client code, and would allow you to default things you might generally not care about.  E.g.

class NonASCIIParameter: # XXX come up with better name
  def __init__(self, text, charset='utf-8', language=''):

It's unfortunate that you have to reorder the arguments from the 3-tuple form of (charset, language, text) but I think you could play games with keyword arguments to make them consistent.

In general the patch looks fine to me, though I suggest splitting test_add_header() into separate tests for each of the three conditions you're testing there.
Date User Action Args
2010-10-04 15:01:21barrysetrecipients: + barry, loewis, tlau, pitrou, ajaksu2, r.david.murray
2010-10-04 15:01:20barrysetmessageid: <>
2010-10-04 15:01:19barrylinkissue1078919 messages
2010-10-04 15:01:13barrycreate