Message117955
RDM, I wonder if it wouldn't be better (in email6) to use an instance to represent the 3-tuple instead? It might make for clearer client code, and would allow you to default things you might generally not care about. E.g.
class NonASCIIParameter: # XXX come up with better name
def __init__(self, text, charset='utf-8', language=''):
It's unfortunate that you have to reorder the arguments from the 3-tuple form of (charset, language, text) but I think you could play games with keyword arguments to make them consistent.
In general the patch looks fine to me, though I suggest splitting test_add_header() into separate tests for each of the three conditions you're testing there. |
|
Date |
User |
Action |
Args |
2010-10-04 15:01:21 | barry | set | recipients:
+ barry, loewis, tlau, pitrou, ajaksu2, r.david.murray |
2010-10-04 15:01:20 | barry | set | messageid: <1286204480.98.0.1212283021.issue1078919@psf.upfronthosting.co.za> |
2010-10-04 15:01:19 | barry | link | issue1078919 messages |
2010-10-04 15:01:13 | barry | create | |
|