Author pitrou
Recipients nirai, pitrou
Date 2010-09-30.17:01:14
SpamBayes Score 2.21212e-06
Marked as misclassified No
Message-id <1285866068.3172.3.camel@localhost.localdomain>
In-reply-to <1285833787.36.0.596999547528.issue9962@psf.upfronthosting.co.za>
Content
Hir Nir,

> BufferedIOBase is not documented to have peek():
> http://docs.python.org/dev/py3k/library/io.html

Ah, you're right.

> Small note about patch:
> 1) IOError string says "read() on write-only...", should be "peek() on write-only..." ?

Indeed.

> 2) Should be min() in self._read(max(self.max_read_chunk, n))

Actually, I think I should have reproduced the algorithm in read(),
where there's a read_size distinct from the size requested by the user.

Thanks for the review, it looks like I should have waited a bit before
committing :)
History
Date User Action Args
2010-09-30 17:01:16pitrousetrecipients: + pitrou, nirai
2010-09-30 17:01:14pitroulinkissue9962 messages
2010-09-30 17:01:14pitroucreate