Message117206
The patch looks good to me. Just a few nitpicks: the local convention seems to be no underscores in helper functions such as gettmarg. I would call is_valid_tm, "checktm" instead. Also, predicate-like naming (is_...) suggests a function without side-effects, while is_valid_tm sets an error when it gets an invalid tm. Also, please add missing comments above gettmarg and is_valid_tm. Finally, please start the function body with a "{" on a new line. Thank you for your submission. |
|
Date |
User |
Action |
Args |
2010-09-23 16:14:39 | belopolsky | set | recipients:
+ belopolsky, lemburg, brett.cannon, pitrou, vstinner, ruseel, alexandre.vassalotti, srid, abbeyj, AmirHabibi |
2010-09-23 16:14:39 | belopolsky | set | messageid: <1285258479.9.0.343415440133.issue6608@psf.upfronthosting.co.za> |
2010-09-23 16:14:38 | belopolsky | link | issue6608 messages |
2010-09-23 16:14:38 | belopolsky | create | |
|