This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients AmirHabibi, abbeyj, alexandre.vassalotti, belopolsky, brett.cannon, lemburg, pitrou, ruseel, srid, vstinner
Date 2010-09-23.16:14:38
SpamBayes Score 0.00012859666
Marked as misclassified No
Message-id <1285258479.9.0.343415440133.issue6608@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks good to me.  Just a few nitpicks: the local convention seems to be no underscores in helper functions such as gettmarg.  I would call is_valid_tm, "checktm" instead.  Also, predicate-like naming (is_...) suggests a function without side-effects, while is_valid_tm sets an error when it gets an invalid tm.  Also, please add missing comments above gettmarg and is_valid_tm.  Finally, please start the function body with a "{" on a new line.  Thank you for your submission.
History
Date User Action Args
2010-09-23 16:14:39belopolskysetrecipients: + belopolsky, lemburg, brett.cannon, pitrou, vstinner, ruseel, alexandre.vassalotti, srid, abbeyj, AmirHabibi
2010-09-23 16:14:39belopolskysetmessageid: <1285258479.9.0.343415440133.issue6608@psf.upfronthosting.co.za>
2010-09-23 16:14:38belopolskylinkissue6608 messages
2010-09-23 16:14:38belopolskycreate