Author r.david.murray
Recipients BreamoreBoy, Red HamsterX, ajaksu2, amaury.forgeotdarc, eric.araujo, pitrou, r.david.murray, sanxiyn
Date 2010-09-06.02:29:48
SpamBayes Score 4.996e-16
Marked as misclassified No
Message-id <1283740191.61.0.97969220367.issue1466065@psf.upfronthosting.co.za>
In-reply-to
Content
Comments on patch:

1) if I'm reading the RFC correctly, to be validating strictly in compliance with the RFC \r and \n should also raise an error.  Do you agree?

2) We've pretty much dropped the convention of adding history notes to the file itself.

3) The original code documented a TypeError on incorrect padding but in py3k in fact raises a binascii.Error, as you noted in the patch.  I wonder if it would be better to raise a binascii.Error on invalid data as well, since it isn't, strictly speaking, a TypeError.  That would also make it easier to move the code into the C module later if that is deemed desirable.

4) The negative in the doc language ("If validate is not set to True...") is awkward and confusing.  Better would be "If validate is False (the default)..."

Since the patch does add an API change (AKA a feature) I think this can only go into 3.2.

I have some additional concerns when considering this in the context of email6.  email6 will have a 'strict' mode where it would be sensible for invalid base64 to raise an error.  But in non-strict mode, it would be ideal to have a way to (a) know if there is invalid input, but still decode it, and (b) decode it even if the padding is off after ignoring the invalid data.  I'm not saying that this patch should try to address those issues, I just want to put them on record in case I want to do something about them later.
History
Date User Action Args
2010-09-06 02:29:51r.david.murraysetrecipients: + r.david.murray, amaury.forgeotdarc, sanxiyn, pitrou, ajaksu2, eric.araujo, Red HamsterX, BreamoreBoy
2010-09-06 02:29:51r.david.murraysetmessageid: <1283740191.61.0.97969220367.issue1466065@psf.upfronthosting.co.za>
2010-09-06 02:29:49r.david.murraylinkissue1466065 messages
2010-09-06 02:29:48r.david.murraycreate