Author eric.araujo
Recipients BreamoreBoy, ajaksu2, eric.araujo, jfinkels, l0nwlf, mnot, r.david.murray
Date 2010-08-21.16:28:41
SpamBayes Score 0.00954617
Marked as misclassified No
Message-id <1282408124.1.0.545221035986.issue1194222@psf.upfronthosting.co.za>
In-reply-to
Content
What I wrote on Rietveld:

I don’t know much about email, but the code itself looks good to me. The fact that you didn’t have to change any test but added one is reassuring (unless it reveals lack of coverage).

http://codereview.appspot.com/217107/diff/1/2#newcode1
Lib/email/_parseaddr.py:1: # Copyright (C) 2002-2007, 2010 Python Software Foundation
“2002-2010” would make more sense.

http://codereview.appspot.com/217107/diff/1/2#newcode24
Lib/email/_parseaddr.py:24: DOY_UNKNOWN = 1
Can you add a comment explaining what DOY means, unless it’s obvious for email specialists?
History
Date User Action Args
2010-08-21 16:28:44eric.araujosetrecipients: + eric.araujo, mnot, ajaksu2, r.david.murray, l0nwlf, jfinkels, BreamoreBoy
2010-08-21 16:28:44eric.araujosetmessageid: <1282408124.1.0.545221035986.issue1194222@psf.upfronthosting.co.za>
2010-08-21 16:28:42eric.araujolinkissue1194222 messages
2010-08-21 16:28:41eric.araujocreate