Author orsenthil
Recipients orsenthil
Date 2010-08-19.17:59:09
SpamBayes Score 0.169961
Marked as misclassified No
Message-id <1282240751.95.0.79564995249.issue9643@psf.upfronthosting.co.za>
In-reply-to
Content
The retry logic and code used by ProxyBasicAuthHandler and ProxyDigestAuthHandler are same as normal authentication handlers. While this reuse is good, there is a problem that, on authentication failure, the HTTPError code is hardcoded to 401, whereas for Proxy cases it should have been 407.

The problematic line is this:


    def http_error_auth_reqed(self, auth_header, host, req, headers):
            ...
            raise HTTPError(req.full_url, 401, "digest auth failed",
                            headers, None)

can be changed by:
- Passing the errcode as arg.
- Or getting it from headers.
History
Date User Action Args
2010-08-19 17:59:12orsenthilsetrecipients: + orsenthil
2010-08-19 17:59:11orsenthilsetmessageid: <1282240751.95.0.79564995249.issue9643@psf.upfronthosting.co.za>
2010-08-19 17:59:10orsenthillinkissue9643 messages
2010-08-19 17:59:09orsenthilcreate