Author eric.araujo
Recipients docs@python, eli.bendersky, eric.araujo, ezio.melotti, georg.brandl, terry.reedy
Date 2010-08-07.14:15:40
SpamBayes Score 1.0927e-05
Marked as misclassified No
Message-id <1281190547.68.0.754234101965.issue9312@psf.upfronthosting.co.za>
In-reply-to
Content
Nice changes! Especially the program/cmdoption directives combo.

Your patch introduces trailing whitespace (good editor settings can show those, as well as hg diff with the color extension) and has one unnecessary change:

-line, ``options.filename`` will be ``"outfile"`` and ``options.verbose`` will be
+line, ``options.filename`` will be ``outfile`` and ``options.verbose`` will be

In this case, the things in ```` are not command line snippets but Python code, so the quotes are regular string notation.

Attached patch fixes that.
History
Date User Action Args
2010-08-07 14:15:48eric.araujosetrecipients: + eric.araujo, georg.brandl, terry.reedy, ezio.melotti, eli.bendersky, docs@python
2010-08-07 14:15:47eric.araujosetmessageid: <1281190547.68.0.754234101965.issue9312@psf.upfronthosting.co.za>
2010-08-07 14:15:46eric.araujolinkissue9312 messages
2010-08-07 14:15:44eric.araujocreate