Author tim.golden
Recipients brian.curtin, gjb1002, gregory.p.smith, markmentovai, ocean-city, terry.reedy, tim.golden, twhitema
Date 2010-08-05.15:09:08
SpamBayes Score 0.000633939
Marked as misclassified No
Message-id <1281020957.2.0.0174076106087.issue3210@psf.upfronthosting.co.za>
In-reply-to
Content
Brian, I'm not sure that the test as rewritten will exercise the error.

The key is that the traceback object will prevent the handles
from being finalised until it is itself finalised. After your
change I expect the handles to release anyway since the traceback
is already finalised.

In other words, I'm not testing that an exception is raised (which
is what the with assertRaises would suggest); I'm testing that
*within the lifetime of the exception* it's still possible to
remove the files which were passed as stdin/out/err where it wasn't
previously.
History
Date User Action Args
2010-08-05 15:09:17tim.goldensetrecipients: + tim.golden, terry.reedy, gregory.p.smith, gjb1002, ocean-city, twhitema, markmentovai, brian.curtin
2010-08-05 15:09:17tim.goldensetmessageid: <1281020957.2.0.0174076106087.issue3210@psf.upfronthosting.co.za>
2010-08-05 15:09:09tim.goldenlinkissue3210 messages
2010-08-05 15:09:08tim.goldencreate