Message 112346 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	belopolsky
Recipients	Tom, belopolsky
Date	2010-08-01.15:36:38
SpamBayes Score	0.012340646
Marked as misclassified	No
Message-id	<1280677000.3.0.251492386238.issue9441@psf.upfronthosting.co.za>
In-reply-to

Content
I noticed that you use timedelta.total_seconds in secs which returns a float while no test covers fractional number of seconds. While not a problem with your choice of tests, equality comparison of floating point values commonly leads to fragile tests. I would suggest that you use delta//timedelta(seconds=1) instead of total_seconds().

I noticed that you use timedelta.total_seconds in secs which returns a float while no test covers fractional number of seconds.  While not a problem with your choice of tests, equality comparison of floating point values commonly leads to fragile tests.  I would suggest that you use delta//timedelta(seconds=1) instead of total_seconds().

History
Date	User	Action	Args
2010-08-01 15:36:40	belopolsky	set	recipients: + belopolsky, Tom
2010-08-01 15:36:40	belopolsky	set	messageid: <1280677000.3.0.251492386238.issue9441@psf.upfronthosting.co.za>
2010-08-01 15:36:39	belopolsky	link	issue9441 messages
2010-08-01 15:36:38	belopolsky	create