Message110541
I have fixed some style nits in your patch. It would be nice to have tests for the different control paths in instantiate(). But, I realize that would be a bit annoying.
Apart from that, the patch looks good. |
|
Date |
User |
Action |
Args |
2010-07-17 07:52:37 | alexandre.vassalotti | set | recipients:
+ alexandre.vassalotti, lemburg, mark.dickinson, belopolsky, pitrou |
2010-07-17 07:52:37 | alexandre.vassalotti | set | messageid: <1279353157.41.0.166596494006.issue5180@psf.upfronthosting.co.za> |
2010-07-17 07:52:35 | alexandre.vassalotti | link | issue5180 messages |
2010-07-17 07:52:35 | alexandre.vassalotti | create | |
|