This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients csernazs, pitrou, skrah
Date 2010-07-13.12:06:01
SpamBayes Score 5.3518403e-07
Marked as misclassified No
Message-id <1279022763.71.0.470174223778.issue9185@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not sure I understand the cause of the problem. Does getcwd() fail on Solaris when the path length is higher than PATH_MAX, even if you pass a big enough buffer?

First, your patch makes getcwd() return an error when the path length is longer than PATH_MAX, which it doesn't today. This is a regression and shouldn't probably go in.

Second, the test_posix change is a bit too tolerant. IMO it should check that the error is ERANGE, and that we are under Solaris. Otherwise the error shouldn't happen, should it?

Also, I wonder why py3k uses a simple hard-coded buffer of 1026 bytes (not even PATH_MAX+2). This is even worse than what you are proposing. I'll open a separate issue for it.
History
Date User Action Args
2010-07-13 12:06:03pitrousetrecipients: + pitrou, csernazs, skrah
2010-07-13 12:06:03pitrousetmessageid: <1279022763.71.0.470174223778.issue9185@psf.upfronthosting.co.za>
2010-07-13 12:06:02pitroulinkissue9185 messages
2010-07-13 12:06:01pitroucreate