Author belopolsky
Recipients Arfrever, belopolsky, benjamin.peterson, eric.smith, ezio.melotti, pitrou, rhettinger
Date 2010-07-07.20:43:28
SpamBayes Score 0.0240399
Marked as misclassified No
Message-id <1278535410.36.0.503773633914.issue8413@psf.upfronthosting.co.za>
In-reply-to
Content
Looks great.  I love the patches where few '+'s are drowning in a sea of '-'s!

A gratuitous nitpick (feel free to ignore).  In

+        val = PyStructSequence_GET_ITEM(obj, i);
         if (cname == NULL || val == NULL) {

The null check for val is now redundant, but won't hurt.
History
Date User Action Args
2010-07-07 20:43:30belopolskysetrecipients: + belopolsky, rhettinger, pitrou, eric.smith, benjamin.peterson, ezio.melotti, Arfrever
2010-07-07 20:43:30belopolskysetmessageid: <1278535410.36.0.503773633914.issue8413@psf.upfronthosting.co.za>
2010-07-07 20:43:28belopolskylinkissue8413 messages
2010-07-07 20:43:28belopolskycreate