Message109481
Patch at http://codereview.appspot.com/1749042.
The idea here is to let the user set CFLAGS on either configure or make (or both), and have later settings appear later in the $CC command line. I left OPT, BASECFLAGS, and EXTRA_CFLAGS around in case people have written scripts using them, but I think they're superfluous as user-visible knobs after this patch.
I prevented AC_PROG_CC from setting a default $CFLAGS value because the values it would set are already put into $BASECFLAGS when appropriate, and @CFLAGS@ needs to appear after @BASECFLAGS@ to allow the user to override Python's defaults at configure time. We could also accomplish this by removing BASECFLAGS and OPT entirely and instead prepending their contents to $CFLAGS in configure. That's a bigger patch, but if any of you feel strongly about it I can do that instead.
I made the same changes for CPPFLAGS and LDFLAGS but no other user-settable variables. I don't have strong opinions about the exact set we support this for, as long as it includes CFLAGS, but these three seemed like a sensible set. |
|
Date |
User |
Action |
Args |
2010-07-07 15:51:13 | jyasskin | set | recipients:
+ jyasskin, lemburg, loewis, brett.cannon, pitrou |
2010-07-07 15:51:13 | jyasskin | set | messageid: <1278517873.84.0.191654592449.issue9189@psf.upfronthosting.co.za> |
2010-07-07 15:51:12 | jyasskin | link | issue9189 messages |
2010-07-07 15:51:10 | jyasskin | create | |
|