This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author dmalcolm
Recipients dmalcolm, pitrou, vstinner
Date 2010-07-06.20:34:26
SpamBayes Score 9.884681e-05
Marked as misclassified No
Message-id <1278448468.55.0.00494163884537.issue8605@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks.  The patch looks good to me, and appears to also fix issue 8482 and issue 9163: compiler optimization across all different compilers and configurations can somewhat arbitrarily break the ability for the debugger to work, and skipping the test in the face of optimization seems the sanest course of action.

Minor nit: given that final_opt is set to "" at the start of the loop, the first conditional in:
    if final_opt and final_opt != '-O0':
appears to be redundant.

Setting "Stage" to "commit review" - I'd commit it (modulo the above nit), but I don't have rights to do so; looking for a committer to review this.
History
Date User Action Args
2010-07-06 20:34:28dmalcolmsetrecipients: + dmalcolm, pitrou, vstinner
2010-07-06 20:34:28dmalcolmsetmessageid: <1278448468.55.0.00494163884537.issue8605@psf.upfronthosting.co.za>
2010-07-06 20:34:27dmalcolmlinkissue8605 messages
2010-07-06 20:34:26dmalcolmcreate