Message109424
Thanks. The patch looks good to me, and appears to also fix issue 8482 and issue 9163: compiler optimization across all different compilers and configurations can somewhat arbitrarily break the ability for the debugger to work, and skipping the test in the face of optimization seems the sanest course of action.
Minor nit: given that final_opt is set to "" at the start of the loop, the first conditional in:
if final_opt and final_opt != '-O0':
appears to be redundant.
Setting "Stage" to "commit review" - I'd commit it (modulo the above nit), but I don't have rights to do so; looking for a committer to review this. |
|
Date |
User |
Action |
Args |
2010-07-06 20:34:28 | dmalcolm | set | recipients:
+ dmalcolm, pitrou, vstinner |
2010-07-06 20:34:28 | dmalcolm | set | messageid: <1278448468.55.0.00494163884537.issue8605@psf.upfronthosting.co.za> |
2010-07-06 20:34:27 | dmalcolm | link | issue8605 messages |
2010-07-06 20:34:26 | dmalcolm | create | |
|