Author ncoghlan
Recipients michael.foord, ncoghlan
Date 2010-06-29.14:06:39
SpamBayes Score 0.0246391
Marked as misclassified No
Message-id <1277820401.6.0.624407039876.issue9110@psf.upfronthosting.co.za>
In-reply-to
Content
Looks pretty good to me, but you may want to doublecheck some of your test criteria.

Firstly, the two "*_with_exception" checks don't look quite right to me. I would have expected to see something like the following for both of them: 

  self.assertIsNotNone(context.exc)
  self.assertIs(context.exc[0], NameError).

Secondly, I can't even begin to guess what the method decoration test is currently trying to show. Why 3 instantiations? Why check the instance assignments rather than the context manager behaviour? Either I'm completely missing something, or this currently isn't testing what you meant to test :)

Finally, you may as well include a second typo test to cover the __enter__ misspelling case.
History
Date User Action Args
2010-06-29 14:06:41ncoghlansetrecipients: + ncoghlan, michael.foord
2010-06-29 14:06:41ncoghlansetmessageid: <1277820401.6.0.624407039876.issue9110@psf.upfronthosting.co.za>
2010-06-29 14:06:40ncoghlanlinkissue9110 messages
2010-06-29 14:06:39ncoghlancreate