Message 108731 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	belopolsky
Recipients	belopolsky, brett.cannon, brian.curtin, grantbow, loewis, pboddie, quale, r.david.murray, rhettinger
Date	2010-06-26.16:12:07
SpamBayes Score	0.0019922478
Marked as misclassified	No
Message-id	<1277568729.69.0.675946497998.issue762963@psf.upfronthosting.co.za>
In-reply-to

Content
I agree with Martin. A proper fix would be to use tm_gmtoff explicitly where available and carry it in time.struct_time. See issue1647654 and issue4086. Interestingly, the issue does not show up on OSX, which being a BSD derivative does have tm_gmtoff in struct tm. While I don't have an affected system to test the patch, it does not look right to me. I would think mktime() should be called after PyArg_Parse, not before because tm_gmtoff may be different for different times.

I agree with Martin.  A proper fix would be to use tm_gmtoff explicitly where available and carry it in time.struct_time.

See issue1647654 and issue4086.

Interestingly, the issue does not show up on OSX, which being a BSD derivative does have tm_gmtoff in struct tm.

While I don't have an affected system to test the patch, it does not look right to me.  I would think mktime() should be called after PyArg_Parse, not before because tm_gmtoff may be different for different times.

History
Date	User	Action	Args
2010-06-26 16:12:10	belopolsky	set	recipients: + belopolsky, loewis, brett.cannon, rhettinger, pboddie, quale, r.david.murray, brian.curtin, grantbow
2010-06-26 16:12:09	belopolsky	set	messageid: <1277568729.69.0.675946497998.issue762963@psf.upfronthosting.co.za>
2010-06-26 16:12:08	belopolsky	link	issue762963 messages
2010-06-26 16:12:07	belopolsky	create