Message10845
Logged In: YES
user_id=80475
Expanding keyspace is generally a good idea; however, the
significance of meta-characters is bound to bite someone in
the behind with a hard to find error. So, please
reconsider single-quote, double-quote, backslash,
greaterthan, lessthan, and pipe.
Looking at first part of the patch, consider:
- removing the TODO on line 31
- wrapping the character list in triple-quotes on line 32
- using the r'' form on line 32 to eliminate backslashes in
the character list
Looking at the second part of the patch, I don't follow (am
perhaps being daft) why expanding the keyspace necessitates
changing the login logic.
The idea of allowing non-ASCII characters would be cool if
the world had already universally accepted Latin-1 coding.
That conflict is the reason that site.py defaults to ASCII
encoding instead of handling non-US codings out of the box. |
|
Date |
User |
Action |
Args |
2007-08-23 14:01:27 | admin | link | issue557704 messages |
2007-08-23 14:01:27 | admin | create | |
|