Author eric.araujo
Recipients belopolsky, brett.cannon, eric.araujo, mark.dickinson, pitrou
Date 2010-06-22.10:56:10
SpamBayes Score 0.0171315
Marked as misclassified No
Message-id <1277204174.83.0.0410411772157.issue8912@psf.upfronthosting.co.za>
In-reply-to
Content
1) Okay, so I’ll refactor some code in patchcheck into a grep-like function to reduce duplication and support adding new checks.

2) I’ll add more useful report. Perhaps I’ll ask first on python-dev to see if I should add a command-line option or just improve it. Also, whether I should use logging or just output file names and lines.

3) Well, if your editor strips trailing spaces and adds final newlines, you won’t ever see make patchcheck complain, will you? Since the report will be helpful only to people with less smart editors, I think I’ll go with replacing instead of just reporting. Tabs will not be replaced, though, just reported.

4) See attached patch for py3k (no idea if this will go into 2.7 too).
History
Date User Action Args
2010-06-22 10:56:14eric.araujosetrecipients: + eric.araujo, brett.cannon, mark.dickinson, belopolsky, pitrou
2010-06-22 10:56:14eric.araujosetmessageid: <1277204174.83.0.0410411772157.issue8912@psf.upfronthosting.co.za>
2010-06-22 10:56:12eric.araujolinkissue8912 messages
2010-06-22 10:56:11eric.araujocreate