Message 10803 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rhettinger
Recipients
Date	2002-05-18.00:12:33
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to

Content
Logged In: YES user_id=80475 Added a patch to add this bug to the testbank. Shallow code review: Patch compiles okay (applied to Py2.3a0). Fixes the original problem. Passes the smell test. Macro style good (only the "var" operand is used more than once; no side-effects except setting "var" to zero upon a resize error). Passes the standard regression tests. Passes regression testing versus my personal (real code) testbank. Will give it a deeper look this week-end. One other thought: should the ValueError be replaced with a MemoryError to make the message consistent with PyList_New?

Logged In: YES 
user_id=80475

Added a patch to add this bug to the testbank.

Shallow code review:  Patch compiles okay (applied to 
Py2.3a0). Fixes the original problem.  Passes the smell 
test.  Macro style good (only the "var" operand is used 
more than once; no side-effects except setting "var" to 
zero upon a resize error).  Passes the standard regression 
tests.  Passes regression testing versus my personal (real 
code) testbank.

Will give it a deeper look this week-end.

One other thought: should the ValueError be replaced with a 
MemoryError to make the message consistent with PyList_New?

History
Date	User	Action	Args
2007-08-23 14:01:23	admin	link	issue556025 messages
2007-08-23 14:01:23	admin	create