Message107742
issue5094g.diff addresses all Mark's suggestions except making struct definition public. I also made a few other changes:
1. Constructor now raises TypeError when offset is not a timedelta instead of ValueError in previous version.
2. NEWS entry no longer says that argument is ignored by tzinfo methods implemented in timezone. (Since these methods now check the type of the argument, it would be misleading to say that arg is ignored.)
3. Added some more tests for error cases.
4. Added ACK for Rafe Kaplan as the author of the original patch. |
|
Date |
User |
Action |
Args |
2010-06-13 18:18:44 | belopolsky | set | recipients:
+ belopolsky, tim.peters, doerwalter, brett.cannon, mark.dickinson, ggenellina, pitrou, techtonik, ajaksu2, kawai, eric.araujo, r.david.murray, rafe, daniel.urban, l0nwlf, akira |
2010-06-13 18:18:44 | belopolsky | set | messageid: <1276453124.35.0.302541902469.issue5094@psf.upfronthosting.co.za> |
2010-06-13 18:18:42 | belopolsky | link | issue5094 messages |
2010-06-13 18:18:42 | belopolsky | create | |
|