Message107210
PyArg_ParseTuple("t") calls PyObject_GetBuffer() and then raise an error if arg->ob_type->tp_as_buffer->bf_releasebuffer is not NULL. I think that it should call PyBuffer_Release(&view) before raising the error, or simply check bf_releasebuffer before calling PyObject_GetBuffer().
getbuffer() calls PyObject_GetBuffer() and then raise an error if the buffer is not contiguous. I think that it should call PyBuffer_Release() before the error.
Attached patch fixes both errors.
Tell me if I'm wrong :-) |
|
Date |
User |
Action |
Args |
2010-06-06 19:11:10 | vstinner | set | recipients:
+ vstinner |
2010-06-06 19:11:10 | vstinner | set | messageid: <1275851470.16.0.472008534505.issue8926@psf.upfronthosting.co.za> |
2010-06-06 19:11:09 | vstinner | link | issue8926 messages |
2010-06-06 19:11:08 | vstinner | create | |
|