Author daniel.urban
Recipients ajaksu2, belopolsky, brett.cannon, daniel.urban, doerwalter, eric.araujo, ggenellina, kawai, l0nwlf, mark.dickinson, pitrou, r.david.murray, rafe, techtonik, tim.peters, vstinner
Date 2010-06-06.06:54:44
SpamBayes Score 0.00066023
Marked as misclassified No
Message-id <1275807287.52.0.356996922752.issue5094@psf.upfronthosting.co.za>
In-reply-to
Content
Isn't it possible, that in the issue5094b.diff patch, in the new_timezone_ex function, in this part:

self = (PyDateTime_TimeZone *)type->tp_alloc(type, 0);
if (self == NULL)
    return NULL;

should be a Py_DECREF(offset) call?

I mean like:

self = (PyDateTime_TimeZone *)type->tp_alloc(type, 0);
if (self == NULL) {
    Py_DECREF(offset);
    return NULL;
}

I think the refcount of offset has always been incremented, so in case of an error, it should be decremented (as in the other error handling parts of the function).
History
Date User Action Args
2010-06-06 06:54:47daniel.urbansetrecipients: + daniel.urban, tim.peters, doerwalter, brett.cannon, mark.dickinson, belopolsky, ggenellina, pitrou, vstinner, techtonik, ajaksu2, kawai, eric.araujo, r.david.murray, rafe, l0nwlf
2010-06-06 06:54:47daniel.urbansetmessageid: <1275807287.52.0.356996922752.issue5094@psf.upfronthosting.co.za>
2010-06-06 06:54:45daniel.urbanlinkissue5094 messages
2010-06-06 06:54:44daniel.urbancreate