Message 106420 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	tarek
Recipients	Christopher.Paolini, loewis, r.david.murray, skrah, srid, tarek, terry.reedy
Date	2010-05-25.09:06:05
SpamBayes Score	8.28573e-05
Marked as misclassified	No
Message-id	<1274778367.25.0.91368443874.issue7511@psf.upfronthosting.co.za>
In-reply-to

Content
Remarks with the patch: - we need to keep the find_vcvarsall() backward compatible. e.g. define a default value for arch. - Next, since this fix is specific to 64bt and since any value in arch will be used as "not 64 bits", I think the patch should be using a boolean tag instead (vs64bits=False). - Last, we need a unit test that runs exclusively in this environment, to demonstrate that youyr fix fixes the error. Let me know if you want to work on the patch, or I can fix it directly. I'd prefer of course if you modify the patch ;)

Remarks with the patch:

- we need to keep the find_vcvarsall() backward compatible. e.g. define a default value for arch.

- Next, since this fix is specific to 64bt and since *any value* in arch will be used as "not 64 bits", I think the patch should be using a boolean tag instead (vs64bits=False).

- Last, we need a unit test that runs exclusively in this environment, to demonstrate that youyr fix fixes the error.

Let me know if you want to work on the patch, or I can fix it directly.
I'd prefer of course if you modify the patch ;)

History
Date	User	Action	Args
2010-05-25 09:06:07	tarek	set	recipients: + tarek, loewis, terry.reedy, r.david.murray, srid, skrah, Christopher.Paolini
2010-05-25 09:06:07	tarek	set	messageid: <1274778367.25.0.91368443874.issue7511@psf.upfronthosting.co.za>
2010-05-25 09:06:06	tarek	link	issue7511 messages
2010-05-25 09:06:05	tarek	create