Author mark.dickinson
Recipients Alexander.Belopolsky, MrJean1, ajaksu2, barry, benjamin.peterson, inducer, mark.dickinson, meador.inge, noufal, pitrou, teoliphant
Date 2010-05-19.19:46:19
SpamBayes Score 0.00142591
Marked as misclassified No
Message-id <1274298381.75.0.275688721039.issue3132@psf.upfronthosting.co.za>
In-reply-to
Content
Hmm.  Something's not quite right: the _struct module fails to compile for me with this patch.  I get:

/Users/dickinsm/python/svn/py3k/Modules/_struct.c: In function ‘s_unpack’:
/Users/dickinsm/python/svn/py3k/Modules/_struct.c:1730: error: ‘PyStructObject’ has no member named ‘s_codes’
/Users/dickinsm/python/svn/py3k/Modules/_struct.c: In function ‘s_unpack_from’:
/Users/dickinsm/python/svn/py3k/Modules/_struct.c:1765: error: ‘PyStructObject’ has no member named ‘s_codes’

The offending lines both look like:

    assert(soself->s_codes != NULL);

presumably that should be:

    assert(soself->s_tree->s_codes != NULL);

After making that change, and successfully rebuilding, this assert triggers:

test_705836 (__main__.StructTest) ... Assertion failed: (soself->s_tree->s_codes != NULL), function s_unpack, file /Users/dickinsm/python/svn/py3k/Modules/_struct.c, line 1730.
History
Date User Action Args
2010-05-19 19:46:22mark.dickinsonsetrecipients: + mark.dickinson, barry, teoliphant, pitrou, inducer, ajaksu2, MrJean1, benjamin.peterson, noufal, meador.inge, Alexander.Belopolsky
2010-05-19 19:46:21mark.dickinsonsetmessageid: <1274298381.75.0.275688721039.issue3132@psf.upfronthosting.co.za>
2010-05-19 19:46:19mark.dickinsonlinkissue3132 messages
2010-05-19 19:46:19mark.dickinsoncreate