This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jjlee
Recipients
Date 2003-04-27.01:31:00
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=261020

The patch for urllib.py is indeed broken, and I think Guido's 
patch is correct.  I agree with the summary Guido gives, which is 
also in agreement with our previous discussion. 
 
A side issue that occurred to me on re-reading the RFC is whether 
301 redirection should be automatic.  A 301 is supposed to 
indicate permanent redirection, so one is supposed to update 
one's URL when a 301 happens. Redirecting automatically doesn't 
allow the user of urllib / urllib2 to do that.  However, I 
suppose that since 2.2 *does* redirect automatically (for both 
urllib and urllib2) it's a bit late to worry about this. 
 
The patched urllib2.py is also broken in two ways: 
 
1. It tries to call req.method() -- which doesn't exist -- rather 
than req.get_method() as it should. 
 
print "Must use pychecker.\n"*100 
 
especially when there are no unit tests... 
 
Anyway, I decided the new get_method method is unnecessary and 
the new patch I'll upload in a minute removes it again. 
 
2. 301 response to POST isn't redirected to GET.  It should be, 
as we agreed earlier. 
 
Just about to upload revised patches, against 2.3beta CVS. 
(urllib2.py.patch2, liburllib2.tex.patch2, liburllib.tex.patch2). 
They need backporting to 2.2 again, too. 
 
Bother. 
 
History
Date User Action Args
2007-08-23 14:01:00adminlinkissue549151 messages
2007-08-23 14:01:00admincreate